Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of test-tidy with duplicated packages. #26587

Merged
merged 1 commit into from May 26, 2020
Merged

Fix output of test-tidy with duplicated packages. #26587

merged 1 commit into from May 26, 2020

Conversation

@jdm
Copy link
Member

jdm commented May 20, 2020

Fixes #25508.
@jdm
Fix output of test-tidy with duplicated packages.
Loading status checks…
4fec987
@highfive
Copy link

highfive commented May 20, 2020

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy_tests/test_tidy.py, python/tidy/servo_tidy_tests/duplicated_package.lock, python/tidy/servo_tidy/tidy.py
@jdm
Copy link
Member Author

jdm commented May 26, 2020

@nox review ping!
@nox
Copy link
Member

nox commented May 26, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

📌 Commit 4fec987 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

⌛ Testing commit 4fec987 with merge 626cb23...
bors-servo added a commit that referenced this pull request May 26, 2020
@bors-servo
Auto merge of #26587 - jdm:tidy-dup-fix, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
626cb23 
Fix output of test-tidy with duplicated packages.

Fixes #25508.
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 26, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

⌛ Testing commit 4fec987 with merge 078e4cb...
bors-servo added a commit that referenced this pull request May 26, 2020
@bors-servo
Auto merge of #26587 - jdm:tidy-dup-fix, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
078e4cb 
Fix output of test-tidy with duplicated packages.

Fixes #25508.
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 26, 2020

@bors-servo retry

  • network issue
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

⌛ Testing commit 4fec987 with merge 43d80b2...
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 43d80b2 to master...
@bors-servo bors-servo merged commit 43d80b2 into servo:master May 26, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Duplicate crate check no longer reports crate names
4 participants
@jdm @highfive @nox @bors-servo
You can’t perform that action at this time.