Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement animationiteration event #26594
Merged
Conversation
highfive
commented
May 21, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 21, 2020
|
|
components/script/animations.rs
Outdated
|
|
||
| for set in sets.values_mut() { | ||
| // When necessary, iterate our running animations to the next iteration. | ||
| // TODO(mrobinson): We need to send animationiteration events here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This event is triggered when an animation iterates. This change also moves iteration out of style calculation to an "update animations" which is the next part of having animation event handling match the HTML spec.
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMay 21, 2020
This event is triggered when an animation iterates. This change also
moves iteration out of style calculation to an "update animations" which
is the next part of having animation event handling match the HTML spec.
This change causes a few more tests to pass. Some of the other tests which
exercise this functionality require
animationstartevents../mach build -ddoes not report any errors./mach test-tidydoes not report any errors