Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client-side logic for WebGPU id recycling #26619

Merged
merged 1 commit into from May 22, 2020
Merged

Implement client-side logic for WebGPU id recycling #26619

merged 1 commit into from May 22, 2020

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented May 22, 2020

  1. Set up WebGPUMsg receiver in script thread and add respective message handler function.
  2. Add kill_xxx_id() methods to Identities.

r?@kvark

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 22, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/identityhub.rs, components/constellation/constellation.rs, components/script/script_thread.rs, components/script/dom/workletglobalscope.rs, components/script/script_runtime.rs
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script/dom/identityhub.rs, components/script/script_thread.rs, components/script/dom/workletglobalscope.rs, components/script/script_runtime.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented May 22, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@kvark
kvark requested changes May 22, 2020
View changes
Copy link
Member

kvark left a comment

Looks great overall, just a few notes
components/constellation/constellation.rs Outdated Show resolved Hide resolved
components/script/script_thread.rs Show resolved Hide resolved
@kunalmohan
Implement client-side logic for WebGPU id recycling
Loading status checks…
39f336b
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-client-id branch from 37659d6 to 39f336b May 22, 2020
@kvark
kvark approved these changes May 22, 2020
View changes
@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation May 22, 2020
@jdm
Copy link
Member

jdm commented May 22, 2020

@bors-servo r=kvark
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2020

📌 Commit 39f336b has been approved by kvark
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing af1036f to master...
@bors-servo bors-servo merged commit af1036f into servo:master May 22, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
WebGPU MVP automation moved this from In progress to Done May 22, 2020
@kunalmohan kunalmohan deleted the kunalmohan:gpu-client-id branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees

@kvark kvark

Labels
None yet
Projects
WebGPU MVP
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kunalmohan @highfive @jdm @bors-servo @kvark
You can’t perform that action at this time.