Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPUSampler to WebGPU implementation #26630

Merged
merged 1 commit into from May 25, 2020
Merged

Add GPUSampler to WebGPU implementation #26630

merged 1 commit into from May 25, 2020
+318 −142

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented May 24, 2020

Add dom_struct and webidl for GPUSampler, implement GPUDevice.createSampler() method.

r?@kvark

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 24, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpusampler.rs, components/script/dom/identityhub.rs, components/script/dom/mod.rs, components/script/dom/gpudevice.rs, components/script/dom/bindings/trace.rs and 3 more
  • @KiChjang: components/script/dom/gpusampler.rs, components/script/dom/identityhub.rs, components/script/dom/mod.rs, components/script/dom/gpudevice.rs, components/script/dom/bindings/trace.rs and 3 more
@highfive
Copy link

highfive commented May 24, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@kvark
kvark requested changes May 24, 2020
View changes
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/webgpu/lib.rs Outdated Show resolved Hide resolved
@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation May 25, 2020
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-sampler branch from 9efbdfa to 77a12d2 May 25, 2020
@kvark
kvark requested changes May 25, 2020
View changes
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/script/dom/identityhub.rs Outdated Show resolved Hide resolved
components/webgpu/lib.rs Outdated Show resolved Hide resolved
components/webgpu/lib.rs Outdated Show resolved Hide resolved
@kunalmohan
Add GPUSampler to WebGPU implementation
Loading status checks…
dd04716 
Add dom_struct and webidl for GPUSampler, implement GPUDevice.createSampler() method.
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-sampler branch from 77a12d2 to dd04716 May 25, 2020
@kunalmohan kunalmohan requested a review from kvark May 25, 2020
@kvark
kvark approved these changes May 25, 2020
View changes
Copy link
Member

kvark left a comment

Beautiful, thank you!
I love the way it gets shaped :) 👍
@kunalmohan kunalmohan requested a review from jdm May 25, 2020
@jdm
Copy link
Member

jdm commented May 25, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

📌 Commit dd04716 has been approved by jdm
@highfive highfive assigned jdm and unassigned kvark May 25, 2020
bors-servo added a commit that referenced this pull request May 25, 2020
@bors-servo
Auto merge of #26630 - kunalmohan:gpu-sampler, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a103ad 
Add GPUSampler to WebGPU implementation

Add dom_struct and webidl for GPUSampler, implement GPUDevice.createSampler() method.

<!-- Please describe your changes on the following line: -->
r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

⌛ Testing commit dd04716 with merge 9a103ad...
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 25, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

⌛ Testing commit dd04716 with merge 95a818e...
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 95a818e to master...
@bors-servo bors-servo merged commit 95a818e into servo:master May 25, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
WebGPU MVP automation moved this from In progress to Done May 25, 2020
@kunalmohan kunalmohan deleted the kunalmohan:gpu-sampler branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
WebGPU MVP
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kunalmohan @highfive @jdm @bors-servo @kvark
You can’t perform that action at this time.