Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse dynamic dispatch in `mozjs::panic::wrap_panic` #26642
Conversation
Pick up servo/rust-mozjs#512 Fixes #26585 This diff is best viewed with "ignore whitespace changes", because of indentation change.
highfive
commented
May 25, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 25, 2020
|
seems good, r=me pending jdm's perf investigation we could also potentially make it a cfg to use dynamic dispatch here, if there is a small but nontrivial perf impact |
|
I've verified that performance stays the same on the majority of the demos at https://servo.org/hl-home/. We may be slightly slower at flinging balls as fast as possible in ballshooter, and the particles might also be slightly slower, but both of those were also within the realm of measurement error, so I'm not particularly concerned. |
|
servo/rust-mozjs#512 has landed @bors-servo r=Manishearth |
|
|
|
|
SimonSapin commentedMay 25, 2020
Pick up servo/rust-mozjs#512
Fixes #26585
This diff is best viewed with "ignore whitespace changes", because of indentation change.