Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remaining animation and transition events #26659

Merged
merged 2 commits into from May 27, 2020
+761 −397
Merged

Add support for remaining animation and transition events #26659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47642e0
Have Animations struct handle rooting nodes
mrobinson May 23, 2020
77aa372
Add support for remaining animation and transition events
mrobinson May 26, 2020
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Have Animations struct handle rooting nodes 

Instead of having `ScriptThread` handle rooting nodes, do this in
`Animations`. This makes it easier to know when it is appropriate to
root and unroot nodes instead of relying on a certain order of events.
This also allows reducing quite a bit the amount of unsafe code.
  • Loading branch information
@mrobinson
mrobinson committed May 26, 2020
commit 47642e0eee1db349d5b933c0cafc4088818db9a0
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.