Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake WebGPU resource creation async and prevent panic during shutdown if WebGPU is enabled. #26660
Conversation
highfive
commented
May 26, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 26, 2020
|
Looks great! We still have a few senders in message variants that we need to consider fro removal, for example one in CommandEncoderFinish seems unnecessary. |
|
Right. I must have missed that. I'll remove that one here itself. |
Remove some garbage code in adapter id checks Prevent panic during shutdown if using WebGPU
a66689a
to
f4d0183
|
@bors-servo r=kvark |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kunalmohan commentedMay 26, 2020
WebGPURequest::RequestAdapter.a. If a buffer is still alive, script tries to send
WebGPURequest::DestroyBufferto server while dropping the buffer during shutdown.servo/components/script/dom/gpubuffer.rs
Lines 118 to 122 in 7170a69
servo/components/script/dom/gpubuffer.rs
Lines 182 to 186 in 7170a69
b. Receiver in script-thread panics with
RecvErroras soon as sender on server side is dropped.servo/components/script/script_thread.rs
Lines 1456 to 1457 in 7170a69
r?@kvark
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors