Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net: shutdown async runtime on exit #26678

Merged
merged 1 commit into from May 30, 2020
Merged

Net: shutdown async runtime on exit #26678

merged 1 commit into from May 30, 2020

Conversation

@gterzian
Copy link
Member

gterzian commented May 27, 2020

Shutting down the async runtime as part of exiting the core resource thread.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 27, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs
@highfive
Copy link

highfive commented May 27, 2020

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@gterzian gterzian requested a review from Manishearth May 27, 2020
@gterzian gterzian marked this pull request as draft May 27, 2020
@Manishearth
Manishearth approved these changes May 27, 2020
View changes
@gterzian
net: shutdown async runtime on exit
Loading status checks…
fa76516
@gterzian gterzian force-pushed the gterzian:shutdown_net_runtime branch from 3bfca50 to fa76516 May 30, 2020
@gterzian gterzian marked this pull request as ready for review May 30, 2020
@gterzian
Copy link
Member Author

gterzian commented May 30, 2020

@Manishearth I put an option around the runtime, maybe there's a better way?
@gterzian gterzian requested a review from Manishearth May 30, 2020
@Manishearth
Copy link
Member

Manishearth commented May 30, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

📌 Commit fa76516 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit fa76516 with merge 5dae012...
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 5dae012 to master...
@bors-servo bors-servo merged commit 5dae012 into servo:master May 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 30, 2020
Merged
4 of 4 tasks complete
@gterzian gterzian deleted the gterzian:shutdown_net_runtime branch May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@gterzian @highfive @Manishearth @bors-servo
You can’t perform that action at this time.