Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove some unused dependency declarations #26698
Merged
Conversation
highfive
commented
May 28, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 28, 2020
|
|
components/style/Cargo.toml
Outdated
| @@ -79,7 +80,7 @@ void = "1.0.2" | |||
|
|
|||
| [build-dependencies] | |||
| lazy_static = "1" | |||
| log = "0.4" | |||
| #log = "0.4" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
May 28, 2020
Author
Member
I didn’t mean to commit this. Reverted, thanks.
log is used unconditionally in the library crate, but only in Gecko mode in the build script. So having this in build-dependencies warns in Servo mode. I didn’t bother to try if Cargo supports having a dependency optional in build-dependencies but non-optional in depnedencies.
This is based on compiling with `RUSTFLAGS="-W unused_crate_dependencies"` (CC rust-lang/rust#72342) in a recent Nightly (more so than used in the tree as of this writing, CC #26661 for work-arounds). Only one crate is actually removed from the dependency graph, others are still dependended from other places.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 29, 2020
Remove some unused dependency declarations This is based on compiling with `RUSTFLAGS="-W unused_crate_dependencies"` (CC rust-lang/rust#72342) in a recent Nightly (more so than used in the tree as of this writing, CC #26661 for work-arounds). Only one crate is actually removed from the dependency graph, others are still dependended from other places.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedMay 28, 2020
This is based on compiling with
RUSTFLAGS="-W unused_crate_dependencies"(CC rust-lang/rust#72342) in a recent Nightly (more so than used in the tree as of this writing, CC #26661 for work-arounds).Only one crate is actually removed from the dependency graph, others are still dependended from other places.