Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GPURenderPipeline #26714

Merged
merged 2 commits into from May 30, 2020
Merged

Implement GPURenderPipeline #26714

merged 2 commits into from May 30, 2020
+664 −24

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented May 29, 2020 •
edited

We need to wait for #26699 to merge before this.
A significant amount of validation still needs to be added. I plan on doing that in a follow-up PR.
r?@kvark

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 29, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/gpupipelinelayout.rs, components/script/dom/gpurenderpipeline.rs, components/script/dom/webidls/GPUDevice.webidl, components/script/dom/identityhub.rs and 7 more
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/gpupipelinelayout.rs, components/script/dom/gpurenderpipeline.rs, components/script/dom/webidls/GPUDevice.webidl, components/script/dom/identityhub.rs and 7 more
@highfive
Copy link

highfive commented May 29, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@kvark kvark mentioned this pull request May 29, 2020
Closed
@kvark
kvark requested changes May 29, 2020
View changes
Copy link
Member

kvark left a comment

Looks great overall, just a few small notes
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/script/dom/gpudevice.rs Show resolved Hide resolved
components/script/dom/gpudevice.rs Outdated Show resolved Hide resolved
components/webgpu/lib.rs Show resolved Hide resolved
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-render-pipeline branch from ade4de4 to 78dac3b May 29, 2020
@kvark
kvark approved these changes May 29, 2020
View changes
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented May 29, 2020

We now need to wait for #26718 instead.
kunalmohan added 2 commits May 29, 2020
@kunalmohan
Allow sequence of nullable dictionary items in webidl
f014f15 
of type "sequence<Dict?> x"
@kunalmohan
Implement GPURenderPipeline
Loading status checks…
130de8b 
Add webidl for GPURenderPipeline and implement GPUDevice.createRenderPipeline()
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-render-pipeline branch from 78dac3b to 130de8b May 30, 2020
@kunalmohan kunalmohan marked this pull request as ready for review May 30, 2020
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented May 30, 2020

I have rebased it and this should now be ready to merge.
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented May 30, 2020

@jdm This PR also includes changes to assert and makeDictionaryName() in CodegenRust.py in a separate commit.
@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation May 30, 2020
@jdm
Copy link
Member

jdm commented May 30, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

📌 Commit 130de8b has been approved by jdm
@highfive highfive assigned jdm and unassigned kvark May 30, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit 130de8b with merge 05e5fbc...
bors-servo added a commit that referenced this pull request May 30, 2020
@bors-servo
Auto merge of #26714 - kunalmohan:gpu-render-pipeline, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05e5fbc 
Implement GPURenderPipeline

<!-- Please describe your changes on the following line: -->
We need to wait for #26699 to merge before this.
A significant amount of validation still needs to be added. I plan on doing that in a follow-up PR.
r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 30, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit 130de8b with merge 9219126...
bors-servo added a commit that referenced this pull request May 30, 2020
@bors-servo
Auto merge of #26714 - kunalmohan:gpu-render-pipeline, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9219126 
Implement GPURenderPipeline

<!-- Please describe your changes on the following line: -->
We need to wait for #26699 to merge before this.
A significant amount of validation still needs to be added. I plan on doing that in a follow-up PR.
r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 30, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit 130de8b with merge e0f3e9b...
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e0f3e9b to master...
@bors-servo bors-servo merged commit e0f3e9b into servo:master May 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
WebGPU MVP automation moved this from In progress to Done May 30, 2020
@kunalmohan kunalmohan deleted the kunalmohan:gpu-render-pipeline branch May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees

@jdm jdm

Labels
None yet
Projects
WebGPU MVP
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kunalmohan @highfive @jdm @bors-servo @kvark
You can’t perform that action at this time.