Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GPURenderPipeline #26714

Merged
merged 2 commits into from May 30, 2020
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Allow sequence of nullable dictionary items in webidl

of type "sequence<Dict?> x"
  • Loading branch information
kunalmohan committed May 30, 2020
commit f014f15d4eaeb52e38faee15dc9a4d0f700d1d7c
@@ -1134,7 +1134,7 @@ def wrapObjectTemplate(templateBody, nullValue, isDefinitelyObject, type,

if type.isDictionary():
# There are no nullable dictionaries
assert not type.nullable()
assert not type.nullable() or (isMember and isMember != "Dictionary")

typeName = "%s::%s" % (CGDictionary.makeModuleName(type.inner),
CGDictionary.makeDictionaryName(type.inner))
@@ -6645,7 +6645,10 @@ def membersNeedTracing(self):

@staticmethod
def makeDictionaryName(dictionary):
return dictionary.identifier.name
if isinstance(dictionary, IDLWrapperType):
return CGDictionary.makeDictionaryName(dictionary.inner)
else:
return dictionary.identifier.name

def makeClassName(self, dictionary):
return self.makeDictionaryName(dictionary)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.