Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove precision of sequence types for WebIDL codegen. #26718
Merged
+4
−4
Conversation
highfive
commented
May 29, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 29, 2020
|
|
|
r? @Manishearth |
|
cc @kunalmohan |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 29, 2020
Improve precision of sequence types for WebIDL codegen. Unlike #26699, this doesn't attempt to improve any of the resulting types and only maintains the status quo. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 30, 2020
Improve precision of sequence types for WebIDL codegen. Unlike #26699, this doesn't attempt to improve any of the resulting types and only maintains the status quo. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 29, 2020
Unlike #26699, this doesn't attempt to improve any of the resulting types and only maintains the status quo.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors