Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the real commit hash for `./servo --version`, not the bundle hash #26720

Merged
merged 4 commits into from Jun 6, 2020
+21 −2
Merged

Show the real commit hash for `./servo --version`, not the bundle hash #26720

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02d69a0
Get the real commit hash, not the bundle hash
camelid May 31, 2020
dd4a558
Add missing brackets
camelid May 31, 2020
e362538
Don't fail if run on non-bundle commit
camelid May 31, 2020
2e5ad99
Use binary strings for compatibility with Python 3
camelid May 31, 2020
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Add missing brackets

  • Loading branch information
@camelid
camelid committed May 31, 2020
commit dd4a558ce51201fe1657e0017471bd3aaa370ac8
2 python/servo/command_base.py
View file
Open in desktop
@@ -742,7 +742,7 @@ def build_env(self, hosts_file_path=None, target=None, is_build=False, test_unit
git_sha = git_bundle_subject.split(' ')[-1]
# Verify that it's a valid commit
# NOTE: this will pass even if `git_sha` is 'master' or another branch or ref
subprocess.check_call('git', 'cat-file', 'commit', git_sha)
subprocess.check_call(['git', 'cat-file', 'commit', git_sha])

git_is_dirty = bool(subprocess.check_output([
'git', 'status', '--porcelain'
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.