Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary generics from low-level script code #26757

Merged
merged 2 commits into from Jun 3, 2020
Merged

Remove unnecessary generics from low-level script code #26757

merged 2 commits into from Jun 3, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jun 2, 2020 •
edited by SimonSapin

This should remove one of the larger offenders from the cargo-llvm-lines output for the script crate.

CC #26713
@highfive
Copy link

highfive commented Jun 2, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/conversions.rs
  • @KiChjang: components/script/dom/bindings/conversions.rs
@highfive
Copy link

highfive commented Jun 2, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Jun 2, 2020

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned nox Jun 2, 2020
@jdm
Copy link
Member Author

jdm commented Jun 2, 2020 •
edited

Together these changes remove ~250k lines from the output of cargo-llvm-lines for script.
@jdm jdm changed the title Remove unnecessary generic from private_from_proto_check_static Remove unnecessary generics from low-level script code Jun 2, 2020
jdm added 2 commits Jun 2, 2020
@jdm
dom: Remove unnecessary generic from private_from_proto_check_static.
9669877
@jdm
dom: Extract non-generic code from Root::new.
Loading status checks…
1feeb23
@jdm jdm force-pushed the jdm:unneeded-generic branch from 2541499 to 1feeb23 Jun 2, 2020
@SimonSapin
Copy link
Member

SimonSapin commented Jun 2, 2020

Nice!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2020

📌 Commit 1feeb23 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2020

⌛ Testing commit 1feeb23 with merge ea491b4...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing ea491b4 to master...
@bors-servo bors-servo merged commit ea491b4 into servo:master Jun 3, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@nox
Copy link
Member

nox commented Jun 25, 2020

Just a side note: the passed function is always a T::derives, which is always implemented as proto_chain[depth] == some_interface_id, so we could probably get rid of the passed function entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @SimonSapin @bors-servo @nox
You can’t perform that action at this time.