Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove support for energy and heartbeats profiling #26788
Merged
Conversation
|
components/profile/README.md
Outdated
| ``` | ||
|
|
||
| The window size is also how many heartbeats will be stored in memory. | ||
|
|
||
| ## Log Files |
This comment has been minimized.
This comment has been minimized.
jdm
Jun 4, 2020
Member
This whole file can be removed; it only documents the logs for heartbeat profiling.
|
Fixed both and squashed |
|
@bors-servo r+ |
|
|
|
Updated unit tests for removed parameters. @bors-servo r=jdm |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJun 4, 2020
Both are disabled by default (energy at compile-time, heartbeats with a run-time option). Neither is tested of CI. Neither has been used in a long time. They might have Undefined Behavior: #26550 (comment). They each depend on a mostly-unmaintained C library. The thread-safety expectation of those libraries are unknown.