Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IRC link with Matrix #26791

Merged
merged 1 commit into from Jun 5, 2020
Merged

Replace IRC link with Matrix #26791

merged 1 commit into from Jun 5, 2020

Conversation

@camelid
Copy link
Contributor

camelid commented Jun 5, 2020

Replace the IRC link in CONTRIBUTING.md with a link to the Matrix room.

Same as servo/servo-starters#55.

  • ./mach build -d does not report any errors (only a docs change)
  • ./mach test-tidy does not report any errors (only a docs change)
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because this is only a docs change
@camelid
Replace IRC link with Matrix
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e54c11a
@camelid
Copy link
Contributor Author

camelid commented Jun 5, 2020

Does this need to be changed in any way?

servo/etc/taskcluster/decision_task.py

Line 694 in bce6ecc

notify_route = "notify.irc-channel.#servo.on-failed"

@jdm
Copy link
Member

jdm commented Jun 5, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

📌 Commit e54c11a has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

⌛ Testing commit e54c11a with merge 7df4655...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 7df4655 to master...
@bors-servo bors-servo merged commit 7df4655 into servo:master Jun 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@camelid @jdm @bors-servo @highfive
You can’t perform that action at this time.