Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace `static mut` with `const`, `static`+`AtomicPtr`, or `static`+`UnsafeCell` #26792

Merged
merged 4 commits into from Jun 5, 2020
Merged

Replace `static mut` with `const`, `static`+`AtomicPtr`, or `static`+`UnsafeCell` #26792

merged 4 commits into from Jun 5, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 5, 2020

Fixes #26550
SimonSapin added 4 commits May 25, 2020
@SimonSapin
Use `const` instead of `static mut` in script/dom/eventtarget.rs
36920ab 
There is no mutability there.
@SimonSapin
Keep DOM proxy handlers as separate named items rather than in one array
3367db6
@SimonSapin
Use atomic pointers instead of `static mut` for DOM proxy handlers
57d8967
@SimonSapin
Use UnsafeCell instead of `static mut` in background_hang_monitor/sam…
Loading status checks…
dbdc442 
…pler_linux.rs
@highfive
Copy link

highfive commented Jun 5, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/eventtarget.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/eventtarget.rs
@highfive
Copy link

highfive commented Jun 5, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian
gterzian approved these changes Jun 5, 2020
View changes
Copy link
Member

gterzian left a comment

LGTM on the sampler changes.
@nox
Copy link
Member

nox commented Jun 5, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

📌 Commit dbdc442 has been approved by nox
@highfive highfive assigned nox and unassigned Manishearth Jun 5, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

⌛ Testing commit dbdc442 with merge 00b57b4...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 00b57b4 to master...
@bors-servo bors-servo merged commit 00b57b4 into master Jun 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the static-mut branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gterzian gterzian

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Replace uses of "static mut" with UnsafeCell
6 participants
@SimonSapin @highfive @nox @bors-servo @gterzian @Manishearth
You can’t perform that action at this time.