Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XHR send to use XMLHttpRequestBodyInit #26794

Merged
merged 2 commits into from Jun 9, 2020
Merged

Update XHR send to use XMLHttpRequestBodyInit #26794

merged 2 commits into from Jun 9, 2020
+19 −114

Conversation

@gterzian
Copy link
Member

gterzian commented Jun 5, 2020

FIX #26723

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@gterzian
update XHR send to use XMLHttpRequestBodyInit
Loading status checks…
dc69065
@highfive
Copy link

highfive commented Jun 5, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/XMLHttpRequest.webidl, components/script/dom/xmlhttprequest.rs
  • @KiChjang: components/script/dom/webidls/XMLHttpRequest.webidl, components/script/dom/xmlhttprequest.rs
@highfive
Copy link

highfive commented Jun 5, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian
Copy link
Member Author

gterzian commented Jun 5, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 5, 2020
@bors-servo
Auto merge of #26794 - gterzian:update_xhr, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49b84a3 
Update XHR send to use XMLHttpRequestBodyInit

<!-- Please describe your changes on the following line: -->

FIX #26723

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

⌛ Trying commit dc69065 with merge 49b84a3...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

💔 Test failed - status-taskcluster
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jun 5, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 5, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24008.
@gterzian
Copy link
Member Author

gterzian commented Jun 5, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 5, 2020
@bors-servo
Auto merge of #26794 - gterzian:update_xhr, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86f0fbc 
Update XHR send to use XMLHttpRequestBodyInit

<!-- Please describe your changes on the following line: -->

FIX #26723

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

⌛ Trying commit 2cfadec with merge 86f0fbc...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2020

💔 Test failed - status-taskcluster
@gterzian
Copy link
Member Author

gterzian commented Jun 5, 2020

Failure was #26804
@gterzian gterzian marked this pull request as ready for review Jun 5, 2020
@gterzian
Copy link
Member Author

gterzian commented Jun 5, 2020

@jdm r? Follow-up on the streams PR, I think this might be a quick r for you...
@jdm
jdm requested changes Jun 8, 2020
View changes
tests/wpt/metadata/MANIFEST.json
@@ -527055,42 +527055,6 @@
}
]
],
"send-data-readablestream.any.js": [

This comment has been minimized.

Sign in to view
@jdm

jdm Jun 8, 2020

Member

We should ensure there is a test that verifies the behaviour of xhr send when a ReadableStream argument is passed. This will make it clear on wpt.fyi if browsers have actually converged on the spec in the future.
@gterzian gterzian force-pushed the gterzian:update_xhr branch from 2cfadec to f1f3af7 Jun 8, 2020
@highfive highfive removed the S-tests-failed label Jun 8, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 8, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24008.
@gterzian
Copy link
Member Author

gterzian commented Jun 8, 2020

@bors-servo try=wpt

@jdm I've added one test to check that ReadableStream is treated as a string if passed as an argument, which is what I understand should be the default behavior(see whatwg/xhr#277 (comment))
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2020

⌛ Trying commit f1f3af7 with merge 5074cfb...
bors-servo added a commit that referenced this pull request Jun 8, 2020
@bors-servo
Auto merge of #26794 - gterzian:update_xhr, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5074cfb 
Update XHR send to use XMLHttpRequestBodyInit

<!-- Please describe your changes on the following line: -->

FIX #26723

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@gterzian gterzian force-pushed the gterzian:update_xhr branch from f1f3af7 to 67fd9e7 Jun 8, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 8, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24008.
@jdm
jdm reviewed Jun 8, 2020
View changes
tests/wpt/web-platform-tests/xhr/setrequestheader-content-type.htm Outdated
"application/xml;charset=ASCII",
"ReadableStream request keeps setRequestHeader() Content-Type and charset"
"text/plain;charset=UTF-8",
'ReadableStream request is treated as a String request."'

This comment has been minimized.

Sign in to view
@jdm

jdm Jun 8, 2020

Member

This test doesn't verify anything about what actual bytes are present in the request due to how the readablestream object is converted to a string. I think it would be wise to do that to avoid accidental incompatibilities.

This comment has been minimized.

Sign in to view
@gterzian

gterzian Jun 9, 2020 •
edited

Author Member

Ok, thanks for checking, I think I have now added the right test, please take another look(by the way this already matches the current behavior).
@gterzian
xhr: update test-suite to reflect use of XMLHttpRequestBodyInit
Loading status checks…
a97d2e3
@gterzian gterzian force-pushed the gterzian:update_xhr branch from 67fd9e7 to a97d2e3 Jun 9, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 9, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24008.
@gterzian
Copy link
Member Author

gterzian commented Jun 9, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2020

⌛ Trying commit a97d2e3 with merge a933945...
bors-servo added a commit that referenced this pull request Jun 9, 2020
@bors-servo
Auto merge of #26794 - gterzian:update_xhr, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a933945 
Update XHR send to use XMLHttpRequestBodyInit

<!-- Please describe your changes on the following line: -->

FIX #26723

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2020

💔 Test failed - status-taskcluster
@gterzian
Copy link
Member Author

gterzian commented Jun 9, 2020

error is curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 104...
@gterzian
Copy link
Member Author

gterzian commented Jun 9, 2020

@jdm r?
@jdm
jdm approved these changes Jun 9, 2020
View changes
Copy link
Member

jdm left a comment

Thanks!
@jdm
Copy link
Member

jdm commented Jun 9, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2020

📌 Commit a97d2e3 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Jun 9, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2020

⌛ Testing commit a97d2e3 with merge 8e3d12b...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 8e3d12b to master...
@bors-servo bors-servo merged commit 8e3d12b into servo:master Jun 9, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:update_xhr branch Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Spec update: use XMLHttpRequestBodyInit for XHR
6 participants
@gterzian @highfive @bors-servo @servo-wpt-sync @jdm @ferjm
You can’t perform that action at this time.