Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite stream and its missing incumbent script environment when newing a new stream #26810

Merged
merged 2 commits into from Jun 13, 2020

Commits on Jun 13, 2020

  1. Avoid sending a new chunk when the body is already done

    As discussed in #26807 (comment), we'd like to
    add a new flag, `in_memory_done`, to `TransmitBodyConnectHandler` so
    that we can correctly finish and drop the sender correctly.
    
    When we send the bytes, we will mark the body as done and we can
    recognize it's already done in next tick so that we can send a Done
    request to finish the sender.
    
    Also, when there comes a redirect request, it will go to `re-extract`
    route, we can set the `done` flag to `false` which means we won't
    stop the IPC routers yet. Then, if the re-extract sent its bytes, we
    will be marked as done again so that we can finish with stopping the IPC
    routes when Chunk request comes.
    CYBAI committed Jun 13, 2020
You can’t perform that action at this time.