Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the writing mode of the containing block when accessing CSS properties #26836

Merged
merged 1 commit into from Jun 10, 2020
Merged

Use the writing mode of the containing block when accessing CSS properties #26836

merged 1 commit into from Jun 10, 2020
+165 −64

Commits on Jun 10, 2020

  1. Use the writing mode of the containing block when accessing CSS prope… 

    …rties

… and converting them to flow-relative geometric values.

These values are almost always used to size and position a fragment within its containing block, so using the mode of the containing block seems more correct.

Note that the `writing-mode` and `direction` properties are disabled in Servo at the moment, so this PR by itself should have no effect: the writing mode of an element is always the same of that of its containing block since they’re both horizontal rtl.
    @SimonSapin
    SimonSapin committed Jun 10, 2020
    Loading status checks…
    08f008a
You can’t perform that action at this time.