New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UWP L10N #26840
Merged
+460
−118
Merged
UWP L10N #26840
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
log and format for wstrings.
- Loading branch information
commit 805b79b32ca009d7c8afc45a02e155d3f925d86c
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
| @@ -0,0 +1,22 @@ | ||
| /* This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| #pragma once | ||
|
|
||
| template <typename... Args> | ||
| std::wstring format(const std::wstring &txt, Args... args) { | ||
| size_t size = swprintf(nullptr, 0, txt.c_str(), args...) + 1; | ||
| if (size <= 0) { | ||
| throw std::runtime_error("Error during formatting."); | ||
| } | ||
| auto ptr = new wchar_t[size]; | ||
|
||
| swprintf(ptr, size, txt.c_str(), args...); | ||
| auto wstr = std::wstring(ptr); | ||
| delete ptr; | ||
| return wstr; | ||
| } | ||
|
|
||
| template <typename... Args> void log(const std::wstring &txt, Args... args) { | ||
| OutputDebugString((format(txt, args...) + L"\r\n").c_str()); | ||
| } | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This looks like we leak this memory every time we call format(). Since the wstring constructor copies the contents of the buffer, we should be able to do this instead: