Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic in canvas thread if webrender isn't reachable #26854

Merged
merged 1 commit into from Jun 11, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jun 10, 2020

This fixes a regression from #26823. This method is only used by the css paint worklet API, and the caller handles a communication error on the channel correctly.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26853
  • There are tests for these changes
@SimonSapin
Copy link
Member

SimonSapin commented Jun 10, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2020

📌 Commit 55fee1f has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2020

Testing commit 55fee1f with merge 264b434...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 264b434 to master...

@bors-servo bors-servo merged commit 264b434 into servo:master Jun 11, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.