Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptaking into account TESTNAME variable in reftest (see #41) #2691
Conversation
highfive
commented
Jun 21, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
hoppipolla-critic-bot
commented
Jun 21, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1869 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
CC: @SimonSapin |
SimonSapin
added a commit
that referenced
this pull request
Jun 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
plaublin commentedJun 21, 2014
With this patch, reftest now accepts as arguments a single test file (src/ref/basic.list), followed by the content of the TESTNAME variable, followed by -- and additional flags given to servo. It is no longer possible to use multiple test files. However, only one such file exists in src/ref.