Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert parent dictionary values when converting dictionaries to JS #26929

Merged
merged 1 commit into from Jun 16, 2020
Merged

Convert parent dictionary values when converting dictionaries to JS #26929

merged 1 commit into from Jun 16, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jun 15, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26928
  • There are tests for these changes OR
@highfive
Copy link

highfive commented Jun 15, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/testbinding.rs, components/script/dom/webidls/TestBinding.webidl
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/testbinding.rs, components/script/dom/webidls/TestBinding.webidl
@highfive
Copy link

highfive commented Jun 15, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member Author

jdm commented Jun 15, 2020

@bors-servo try=wpt
@jdm
Copy link
Member Author

jdm commented Jun 15, 2020

r? @nox
bors-servo added a commit that referenced this pull request Jun 15, 2020
@bors-servo
Auto merge of #26929 - jdm:dict-jsval, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
848a957 
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2020

⌛ Trying commit 22ddd67 with merge 848a957...
@highfive highfive assigned nox and unassigned SimonSapin Jun 15, 2020
@jdm jdm force-pushed the jdm:dict-jsval branch from 22ddd67 to 824fe21 Jun 15, 2020
@CYBAI
Copy link
Collaborator

CYBAI commented Jun 16, 2020 

 0:07.83�(B /repo/tests/wpt/mozilla/meta/MANIFEST.json  0  error�(B  mozilla/dictionary_to_jsval.html in manifest but removed from source.  (wpt-manifest)�(B
 0:07.83�(B ERROR�(B Manifest /repo/tests/wpt/mozilla/meta/MANIFEST.json is outdated, use |./mach update-manifest| to fix.
@jdm jdm force-pushed the jdm:dict-jsval branch from 824fe21 to 41d1745 Jun 16, 2020
@jdm
Copy link
Member Author

jdm commented Jun 16, 2020

The try run passed apart from the missing test file.
@jdm
Copy link
Member Author

jdm commented Jun 16, 2020

Review ping @nox.
@jdm jdm force-pushed the jdm:dict-jsval branch from 41d1745 to 8c31351 Jun 16, 2020
@nox
Copy link
Member

nox commented Jun 16, 2020

Nice.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

📌 Commit 8c31351 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

⌛ Testing commit 8c31351 with merge cd47c16...
bors-servo added a commit that referenced this pull request Jun 16, 2020
@bors-servo
Auto merge of #26929 - jdm:dict-jsval, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd47c16 
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

💔 Test failed - status-taskcluster
@jdm
dom: Convert parent dictionary values when converting dictionaries to…
Loading status checks…
edf86d1 
… JS.
@jdm jdm force-pushed the jdm:dict-jsval branch from 8c31351 to edf86d1 Jun 16, 2020
@jdm
Copy link
Member Author

jdm commented Jun 16, 2020

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

📌 Commit edf86d1 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

⌛ Testing commit edf86d1 with merge 27c93a6...
bors-servo added a commit that referenced this pull request Jun 16, 2020
@bors-servo
Auto merge of #26929 - jdm:dict-jsval, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27c93a6 
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jun 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

⌛ Testing commit edf86d1 with merge 0ce03d4...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 0ce03d4 to master...
@bors-servo bors-servo merged commit 0ce03d4 into servo:master Jun 16, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

ToJSVal for webidl dictionaries ignores the parent field
6 participants
@jdm @highfive @bors-servo @CYBAI @nox @SimonSapin
You can’t perform that action at this time.