Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine AnimationAndTransitionDeclarations and AnimationRules #26942

Merged
merged 1 commit into from Jun 16, 2020
Merged

Combine AnimationAndTransitionDeclarations and AnimationRules #26942

merged 1 commit into from Jun 16, 2020

Conversation

@mrobinson
Copy link
Member

mrobinson commented Jun 16, 2020

These two structs are very similar, so we can combine them.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they should not change behavior.
@mrobinson
Combine AnimationAndTransitionDeclarations and AnimationRules
Loading status checks…
36701e0 
These two structs are very similar, so we can combine them.
@mrobinson mrobinson requested a review from emilio Jun 16, 2020
@highfive
Copy link

highfive commented Jun 16, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/style_resolver.rs, components/style/rule_collector.rs, components/style/dom.rs, components/style/properties/declaration_block.rs, components/style/animation.rs and 1 more
@highfive
Copy link

highfive commented Jun 16, 2020

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
emilio approved these changes Jun 16, 2020
View changes
Copy link
Member

emilio left a comment

Looks great, thank you!
@emilio
Copy link
Member

emilio commented Jun 16, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

📌 Commit 36701e0 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

⌛ Testing commit 36701e0 with merge b4c2d3b...
@bors-servo bors-servo mentioned this pull request Jun 16, 2020
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

☀️ Test successful - status-taskcluster
Approved by: emilio
Pushing b4c2d3b to master...
@bors-servo bors-servo merged commit b4c2d3b into servo:master Jun 16, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:combine-declaration-structs branch Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mrobinson @highfive @emilio @bors-servo
You can’t perform that action at this time.