Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCancel animations for nodes which are removed from the DOM #26953
Conversation
highfive
commented
Jun 17, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 17, 2020
|
|
components/script/dom/node.rs
Outdated
| self.owner_doc().cancel_animations_for_node(self); | ||
| unsafe { | ||
| self.style_and_layout_data | ||
| .borrow_for_script_deallocation() |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
Jun 17, 2020
Author
Member
That's right. I've pushed a new version of the branch that uses borrow_mut() as well as fixing some test expectations.
This includes nodes which are being reparented.
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJun 17, 2020
•
edited
This includes nodes which are being reparented.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors