Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCompute content sizes lazily in layout 2020 #26968
Conversation
highfive
commented
Jun 18, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 18, 2020
|
|
|
@bors-servo try=wpt-2020 |
Compute content sizes lazily in layout 2020
|
|
| @@ -144,10 +134,40 @@ impl IndependentFormattingContext { | |||
| } | |||
| } | |||
|
|
|||
| pub fn content_sizes(&self) -> ContentSizes { | |||
| pub fn outer_inline( | |||
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jun 18, 2020
Member
Nit: please rename this to outer_inline_content_sizes, and similarly the next method
| let container = BlockContainer::InlineFormattingContext( | ||
| builder.ongoing_inline_formatting_context, | ||
| ); | ||
| return (container, builder.contains_floats, content_sizes); | ||
| return (container, builder.contains_floats); | ||
| } | ||
| builder.end_ongoing_inline_formatting_context(); | ||
| } | ||
|
|
||
| struct Accumulator { |
This comment has been minimized.
This comment has been minimized.
| match &self { | ||
| Self::BlockLevelBoxes(boxes) => { | ||
| let mut content_sizes = ContentSizes::zero(); | ||
| for box_ in boxes { |
This comment has been minimized.
This comment has been minimized.
|
I took the liberty of pushing to your branch. I’d like to land it in order to rebase another branch on top of it. @bors-servo r+ |
|
|
…apin Compute content sizes lazily in layout 2020
|
|
|
@bors-servo retry |
…apin Compute content sizes lazily in layout 2020
|
|
|
@bors-servo retry |
|
@bors-servo retry #26895 |
|
|
nox commentedJun 18, 2020
No description provided.