Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently ignore failures to queue websocket tasks #26983

Merged
merged 1 commit into from Jun 22, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jun 19, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26977
  • There are tests for these changes
@highfive
Copy link

highfive commented Jun 19, 2020

Heads up! This PR modifies the following files:

@jdm
Copy link
Member Author

jdm commented Jun 19, 2020

r? @nox

@highfive highfive assigned nox and unassigned ferjm Jun 19, 2020
@nox
Copy link
Member

nox commented Jun 22, 2020

Good.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

📌 Commit 2498808 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

Testing commit 2498808 with merge 1dc41b3...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 1dc41b3 to master...

@bors-servo bors-servo merged commit 1dc41b3 into servo:master Jun 22, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.