Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stronger atomic guarantee when cancelling tasks #26998

Merged
merged 1 commit into from Jul 6, 2020

Conversation

@gterzian
Copy link
Member

gterzian commented Jun 20, 2020

In the context of #22507

Note that the "other side" of these operations is at

.map_or(false, |cancelled| cancelled.load(Ordering::SeqCst))


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Jun 20, 2020

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Jun 20, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian gterzian force-pushed the gterzian:improve_task_cancelling branch from a540fc1 to 58259c1 Jun 20, 2020
@jdm
Copy link
Member

jdm commented Jul 6, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

📌 Commit 58259c1 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Jul 6, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

Testing commit 58259c1 with merge 1cd78e7...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 1cd78e7 to master...

@bors-servo bors-servo merged commit 1cd78e7 into servo:master Jul 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:improve_task_cancelling branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.