Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP-cache refresh bug #26999

Closed
wants to merge 1 commit into from
Closed

Fix HTTP-cache refresh bug #26999

wants to merge 1 commit into from

Conversation

@gterzian
Copy link
Member

gterzian commented Jun 20, 2020

FIX #24385

following up on #24388

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@gterzian
fetch/http-cache: add test for 304 select resource for update failure
Loading status checks…
a6a856c
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jun 20, 2020
Closed
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 20, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.
@gterzian gterzian mentioned this pull request Jun 20, 2020
Open
0 of 3 tasks complete
@gterzian gterzian changed the title fetch/http-cache: add test for 304 select resource for update failure Fix HTTP-cache refersh bug Jun 20, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 20, 2020

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.
@gterzian gterzian changed the title Fix HTTP-cache refersh bug Fix HTTP-cache refresh bug Jun 20, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 20, 2020

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.
@gterzian gterzian marked this pull request as draft Jun 20, 2020
@gterzian
Copy link
Member Author

gterzian commented Jun 25, 2020

Doesn't seem necessary anymore. See whatwg/fetch#950
@gterzian gterzian closed this Jun 25, 2020
@gterzian gterzian deleted the gterzian:fix_cache_revalidationwq branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Reload goes back in time (http cache issue?)
4 participants
@gterzian @servo-wpt-sync @SimonSapin @highfive
You can’t perform that action at this time.