Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize colorama only once #27006

Merged
merged 1 commit into from Jun 20, 2020
Merged

Initialize colorama only once #27006

merged 1 commit into from Jun 20, 2020
+1 −2

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Jun 20, 2020 •
edited

Repeated initialization wraps colorama inside colorama, making the loop O(n^2) and causes stack overflow when running mach test-tidy --all.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@saschanaz
Initialize colorama only once
Loading status checks…
97bfab7
@highfive
Copy link

highfive commented Jun 20, 2020

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Jun 20, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2020

📌 Commit 97bfab7 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jun 20, 2020
bors-servo added a commit that referenced this pull request Jun 20, 2020
@bors-servo
Auto merge of #27006 - saschanaz:single-init, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e550d7d 
Initialize colorama only once

<!-- Please describe your changes on the following line: -->

Repeated initialization wraps colorama inside colorama, making the loop O(n^2) and causes stack overflow when running `mach test-tidy --all`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2020

⌛ Testing commit 97bfab7 with merge e550d7d...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2020

⌛ Testing commit 97bfab7 with merge e2193b2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e2193b2 to master...
@bors-servo bors-servo merged commit e2193b2 into servo:master Jun 20, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@saschanaz @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.