Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow embedder to bypass devtools prompt #27025

Merged
merged 2 commits into from Jun 22, 2020
Merged

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jun 22, 2020

This introduces a token shared by servo and the embedder that can be used during the initial phase of the devtools connection.

Added also a commit to remove the devtools server panel. We just print the devtools port in the console now.

@jdm
Copy link
Member

jdm commented Jun 22, 2020

@bors-servo r+
Nice solution!

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

📌 Commit 9371b72 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

Testing commit 9371b72 with merge 0a91394...

bors-servo added a commit that referenced this pull request Jun 22, 2020
Allow embedder to bypass devtools prompt

This introduces a token shared by servo and the embedder that can be used during the initial phase of the devtools connection.

Added also a commit to remove the devtools server panel. We just print the devtools port in the console now.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jun 22, 2020

@bors-servo retry

bors-servo added a commit that referenced this pull request Jun 22, 2020
Allow embedder to bypass devtools prompt

This introduces a token shared by servo and the embedder that can be used during the initial phase of the devtools connection.

Added also a commit to remove the devtools server panel. We just print the devtools port in the console now.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

Testing commit 9371b72 with merge 922eeb9...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jun 22, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

Testing commit 9371b72 with merge ed46f00...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing ed46f00 to master...

@bors-servo bors-servo merged commit ed46f00 into servo:master Jun 22, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.