Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested modules while imported under more than 3 levels #27034

Merged
merged 2 commits into from Jun 23, 2020

Commits on Jun 23, 2020

  1. Rollback to recursively check dependency status

    In https://github.com/servo/servo/pull/26395/files#diff-3fe97584f564214ec8e7ebbf91747e03L253-R318,
    we moved from `recursive checking` of dependency status to check only the
    _current module_'s dependency status and its descendant dependency status and
    also circular dependency status.
    
    However, it will cause an issue.
    
    For example, if the module dependency is like following
    
    ```
    a -> b -> c -> d -> e
    f -> g -> h -> c -> d -> e
    ```
    
    In this example, if the d module is still under fetching but g is trying
    to advance to finish. Then, it will cause a panic because module d is
    g's grand-grand-grand-descendant which means it's still under fetching
    and we can't instantiate module g.
    
    Ideally, we should get rid of the checking in #26903 so, before #26903
    fixed, we can just move back to the recursive checking way which will
    ensure all descendants are not fetching.
    CYBAI committed Jun 23, 2020
  2. Test imports under more than 3 levels in different modules

    CYBAI committed Jun 23, 2020
You can’t perform that action at this time.