Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Console grouping APIs. #27088
Merged
+76
−59
Conversation
highfive
commented
Jun 25, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 25, 2020
|
|
|
Found wrong spec link |
|
r? @ferjm |
|
r=me with the spec links fixed |
| * © Copyright 2014 Mozilla Foundation. | ||
| */ | ||
|
|
||
| // https://console.spec.whatwg.org/ |
This comment has been minimized.
This comment has been minimized.
ferjm
Jul 1, 2020
Member
This needs to be added to https://dxr.mozilla.org/servo/source/python/tidy/servo_tidy/tidy.py#80
|
@bors-servo r=ferjm |
|
|
|
@bors-servo r- |
|
@bors-servo r=ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 7, 2020
Implement Console grouping APIs. These are used by Hubs and other sites we want to run. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #9274 - [x] These changes do not require tests because we can't test stdout content or devtools messages.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 7, 2020
Implement Console grouping APIs. These are used by Hubs and other sites we want to run. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #9274 - [x] These changes do not require tests because we can't test stdout content or devtools messages.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJun 25, 2020
These are used by Hubs and other sites we want to run.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors