Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay initializing servo GL until as late as possible #27142

Merged
merged 1 commit into from Jul 8, 2020
Merged

Delay initializing servo GL until as late as possible #27142

merged 1 commit into from Jul 8, 2020

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 1, 2020

Initialize the GL state for the gstreamer plugin as late as possible.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27013
  • These changes do not require tests because it's a gstreamer plugin issue
@highfive
Copy link

highfive commented Jul 1, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@ferjm
ferjm approved these changes Jul 6, 2020
View changes
Copy link
Member

ferjm left a comment

LGTM!

Unit tests are failing though.

@bors-servo try=linux
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 7, 2020

Hmm, that's an odd failure, let's see if it's transitory. @bors-servo r=ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

📌 Commit 56f6808 has been approved by ferjm
@highfive highfive assigned ferjm and unassigned nox Jul 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

⌛ Testing commit 56f6808 with merge 3447b4a...
bors-servo added a commit that referenced this pull request Jul 7, 2020
@bors-servo
Auto merge of #27142 - asajeffrey:gstplugin-lazy-gl-init, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3447b4a 
Delay initializing servo GL until as late as possible

<!-- Please describe your changes on the following line: -->

Initialize the GL state for the gstreamer plugin as late as possible.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27013
- [x] These changes do not require tests because it's a gstreamer plugin issue

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 7, 2020 

error: unused import: `glib::translate::ToGlibPtr`
  --> ports/gstplugin/servowebsrc.rs:27:5
   |
27 | use glib::translate::ToGlibPtr;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
error: unused import: `gstreamer::gst_error_msg`
  --> ports/gstplugin/servowebsrc.rs:31:5
   |
31 | use gstreamer::gst_error_msg;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
error: unused import: `gstreamer::ResourceError`
  --> ports/gstplugin/servowebsrc.rs:51:5
   |
51 | use gstreamer::ResourceError;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 3 previous errors
error: could not compile `servo-gst-plugin`.
@asajeffrey
Delay initializing servo GL until as late as possible
Loading status checks…
9522056
@asajeffrey asajeffrey force-pushed the asajeffrey:gstplugin-lazy-gl-init branch from 56f6808 to 9522056 Jul 7, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 7, 2020

@bors-servo r=ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

📌 Commit 9522056 has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

⌛ Testing commit 9522056 with merge 39404a6...
bors-servo added a commit that referenced this pull request Jul 7, 2020
@bors-servo
Auto merge of #27142 - asajeffrey:gstplugin-lazy-gl-init, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
39404a6 
Delay initializing servo GL until as late as possible

<!-- Please describe your changes on the following line: -->

Initialize the GL state for the gstreamer plugin as late as possible.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27013
- [x] These changes do not require tests because it's a gstreamer plugin issue

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster
bors-servo added a commit that referenced this pull request Jul 7, 2020
@bors-servo
Auto merge of #27142 - asajeffrey:gstplugin-lazy-gl-init, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
40b75eb 
Delay initializing servo GL until as late as possible

<!-- Please describe your changes on the following line: -->

Initialize the GL state for the gstreamer plugin as late as possible.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27013
- [x] These changes do not require tests because it's a gstreamer plugin issue

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 7, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

⌛ Testing commit 9522056 with merge 7e04d3e...
bors-servo added a commit that referenced this pull request Jul 7, 2020
@bors-servo
Auto merge of #27142 - asajeffrey:gstplugin-lazy-gl-init, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e04d3e 
Delay initializing servo GL until as late as possible

<!-- Please describe your changes on the following line: -->

Initialize the GL state for the gstreamer plugin as late as possible.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27013
- [x] These changes do not require tests because it's a gstreamer plugin issue

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 7, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

⌛ Testing commit 9522056 with merge 5354e1c...
bors-servo added a commit that referenced this pull request Jul 7, 2020
@bors-servo
Auto merge of #27142 - asajeffrey:gstplugin-lazy-gl-init, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5354e1c 
Delay initializing servo GL until as late as possible

<!-- Please describe your changes on the following line: -->

Initialize the GL state for the gstreamer plugin as late as possible.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27013
- [x] These changes do not require tests because it's a gstreamer plugin issue

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 8, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 8, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 8, 2020

⌛ Testing commit 9522056 with merge ea9ecd6...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 8, 2020

☀️ Test successful - status-taskcluster
Approved by: ferjm
Pushing ea9ecd6 to master...
@bors-servo bors-servo merged commit ea9ecd6 into servo:master Jul 8, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees

@ferjm ferjm

Labels
P-gst-plugin
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

GStreamer plugin fails to get GL context
6 participants
@asajeffrey @highfive @bors-servo @jdm @ferjm @nox
You can’t perform that action at this time.