Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UWP: support virtual keyboard #27149

Merged
merged 1 commit into from Jul 3, 2020
Merged

UWP: support virtual keyboard #27149

merged 1 commit into from Jul 3, 2020

Conversation

paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 2, 2020 •
edited by atouchet

Fix #26898 and fix #26680.

@jdm: can you test on the device?

@highfive
Copy link

highfive commented Jul 2, 2020

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Jul 2, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Jul 3, 2020

@bors-servo r+
Tested on device.

@bors-servo
Copy link
Contributor

📌 Commit 34265c8 has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Jul 3, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit 34265c8 with merge ee56d5d...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing ee56d5d to master...

@bors-servo bors-servo merged commit ee56d5d into servo:master Jul 3, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual keyboard does not appear when text inputs are focused No keyboard events in desktop UWP
5 participants
@paulrouget @highfive @jdm @bors-servo @SimonSapin