Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mediadevices.enumeratedevices #27152

Merged
merged 1 commit into from Jul 10, 2020
Merged

Mediadevices.enumeratedevices #27152

merged 1 commit into from Jul 10, 2020

Conversation

ferjm
Copy link
Member

@ferjm ferjm commented Jul 2, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26877

@highfive
Copy link

highfive commented Jul 2, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MediaDevices.webidl, components/script/dom/mediadeviceinfo.rs, components/script/dom/mod.rs, components/script/dom/webidls/MediaDeviceInfo.webidl, components/script/dom/mediadevices.rs
  • @KiChjang: components/script/dom/webidls/MediaDevices.webidl, components/script/dom/mediadeviceinfo.rs, components/script/dom/mod.rs, components/script/dom/webidls/MediaDeviceInfo.webidl, components/script/dom/mediadevices.rs

@highfive
Copy link

highfive commented Jul 2, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@ferjm ferjm marked this pull request as draft Jul 2, 2020
@ferjm
Copy link
Member Author

ferjm commented Jul 2, 2020

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2020

⌛ Trying commit 2e0982c with merge 104ddc9...

bors-servo added a commit that referenced this issue Jul 2, 2020
@bors-servo
Auto merge of #27152 - ferjm:mediadevices.enumeratedevices, r=<try>
104ddc9 
Mediadevices.enumeratedevices

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26877
@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2020

💔 Test failed - status-taskcluster

@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2020

☔ The latest upstream changes (presumably #27143) made this pull request unmergeable. Please resolve the merge conflicts.

@ferjm ferjm force-pushed the mediadevices.enumeratedevices branch from 2e0982c to 8c575ae Compare Jul 7, 2020
Manishearth
Manishearth approved these changes Jul 8, 2020
View changes
Copy link
Member

@Manishearth Manishearth left a comment

we should do the "running in parallel" but, btu aside from that, r=me

@ferjm ferjm force-pushed the mediadevices.enumeratedevices branch from 8c575ae to cd90293 Compare Jul 10, 2020
@ferjm ferjm marked this pull request as ready for review Jul 10, 2020
@ferjm ferjm force-pushed the mediadevices.enumeratedevices branch from cd90293 to c0fb6c8 Compare Jul 10, 2020
@ferjm
Copy link
Member Author

ferjm commented Jul 10, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

📌 Commit c0fb6c8 has been approved by Manishearth

bors-servo added a commit that referenced this issue Jul 10, 2020
@bors-servo
Auto merge of #27152 - ferjm:mediadevices.enumeratedevices, r=Manishe…
244c7c5 
…arth

Mediadevices.enumeratedevices

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26877
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit c0fb6c8 with merge 244c7c5...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

💔 Test failed - status-taskcluster

@ferjm
Copy link
Member Author

ferjm commented Jul 10, 2020

@bors-servo retry

#25237

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit c0fb6c8 with merge fb243a3...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing fb243a3 to master...

@bors-servo bors-servo merged commit fb243a3 into servo:master Jul 10, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MediaDevices.enumerateDevices
4 participants
@ferjm @highfive @bors-servo @Manishearth