Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebGPU update presentation data asynchronously #27154
Conversation
highfive
commented
Jul 2, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 2, 2020
|
|
|
I am facing one problem here. Inside the (There are some debug logs here which I'll remove once this problem gets solved) |
|
Looks reasonable |
kunalmohan
force-pushed the
kunalmohan:async-presentation
branch
from
a14ac8c
to
b672b78
|
The error was probably due to the data-carrying capacity of IpcSender. Reading the data in I have also edited the buffer data exchange between content process and server to use |
|
Much nicer! One concern though |
|
@bors-servo r+ |
|
|
WebGPU update presentation data asynchronously <!-- Please describe your changes on the following line: --> This PR aims to make updating Webrender presentation data non-blocking. A callback is passed to the `buffer_map_async()` fn wherein the data is read and a message sent to the server itself to write the data into the shared `PresentationData` struct object. r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
WebGPU update presentation data asynchronously <!-- Please describe your changes on the following line: --> This PR aims to make updating Webrender presentation data non-blocking. A callback is passed to the `buffer_map_async()` fn wherein the data is read and a message sent to the server itself to write the data into the shared `PresentationData` struct object. r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
kunalmohan commentedJul 2, 2020
This PR aims to make updating Webrender presentation data non-blocking.
A callback is passed to the
buffer_map_async()fn wherein the data is read and a message sent to the server itself to write the data into the sharedPresentationDatastruct object.r?@kvark
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors