WebGPU update presentation data asynchronously #27154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
|
I am facing one problem here. Inside the (There are some debug logs here which I'll remove once this problem gets solved) |
kunalmohan
force-pushed
the
async-presentation
branch
from
a14ac8c to
b672b78
Compare
|
The error was probably due to the data-carrying capacity of IpcSender. Reading the data in I have also edited the buffer data exchange between content process and server to use |
kvark
approved these changes
Jul 3, 2020
|
@bors-servo r+ |
|
📌 Commit b672b78 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
added a commit
that referenced
this pull request
Jul 3, 2020
WebGPU update presentation data asynchronously <!-- Please describe your changes on the following line: --> This PR aims to make updating Webrender presentation data non-blocking. A callback is passed to the `buffer_map_async()` fn wherein the data is read and a message sent to the server itself to write the data into the shared `PresentationData` struct object. r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
added a commit
that referenced
this pull request
Jul 3, 2020
WebGPU update presentation data asynchronously <!-- Please describe your changes on the following line: --> This PR aims to make updating Webrender presentation data non-blocking. A callback is passed to the `buffer_map_async()` fn wherein the data is read and a message sent to the server itself to write the data into the shared `PresentationData` struct object. r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
highfive
added
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make updating Webrender presentation data non-blocking.
A callback is passed to the
buffer_map_async()fn wherein the data is read and a message sent to the server itself to write the data into the sharedPresentationDatastruct object.r?@kvark
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors