Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub isContextLost API. #27168

Merged
merged 1 commit into from Jul 6, 2020
Merged

Add stub isContextLost API. #27168

merged 1 commit into from Jul 6, 2020
+17 −24

Conversation

@jdm
Copy link
Member

jdm commented Jul 3, 2020

We don't support losing contexts yet, so it's not lying to say that the context is never lost.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27116
  • There are tests for these changes
@jdm
webgl: Add stub isContextLost API.
Loading status checks…
795560a
@highfive
Copy link

highfive commented Jul 3, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl, components/script/dom/webgl2renderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl, components/script/dom/webgl2renderingcontext.rs
@jdm
Copy link
Member Author

jdm commented Jul 3, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned ferjm Jul 3, 2020
@jdm
Copy link
Member Author

jdm commented Jul 3, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2020

⌛ Trying commit 795560a with merge 689d3c6...
bors-servo added a commit that referenced this pull request Jul 3, 2020
@bors-servo
Auto merge of #27168 - jdm:gl-fake-context-lost, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
689d3c6 
Add stub isContextLost API.

We don't support losing contexts yet, so it's not lying to say that the context is never lost.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27116
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@Manishearth
Copy link
Member

Manishearth commented Jul 6, 2020 •
edited by jdm

@bors-servo r+ try-
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

📌 Commit 795560a has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

⌛ Testing commit 795560a with merge b5d782a...
bors-servo added a commit that referenced this pull request Jul 6, 2020
@bors-servo
Auto merge of #27168 - jdm:gl-fake-context-lost, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5d782a 
Add stub isContextLost API.

We don't support losing contexts yet, so it's not lying to say that the context is never lost.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27116
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jul 6, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

⌛ Testing commit 795560a with merge 22a7522...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 22a7522 to master...
@bors-servo bors-servo merged commit 22a7522 into servo:master Jul 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

WebGLRenderingContext. isContextLost() is undefined
5 participants
@jdm @highfive @bors-servo @Manishearth @ferjm
You can’t perform that action at this time.