Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GPUQueue write methods and update wgpu-core #27173

Merged
merged 2 commits into from Jul 5, 2020

Conversation

kunalmohan
Copy link
Collaborator

@kunalmohan kunalmohan commented Jul 4, 2020

Implements GPUQueue.writeBuffer and GPUQueue.writeTexture.

r?@kvark


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive
Copy link

highfive commented Jul 4, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpuadapter.rs, components/script/dom/gpuqueue.rs, components/script/dom/gpudevice.rs, components/script/dom/webidls/GPUBuffer.webidl, components/script/dom/webidls/GPUQueue.webidl and 2 more
  • @KiChjang: components/script/dom/gpuadapter.rs, components/script/dom/gpuqueue.rs, components/script/dom/gpudevice.rs, components/script/dom/webidls/GPUBuffer.webidl, components/script/dom/webidls/GPUQueue.webidl and 2 more

@highfive
Copy link

highfive commented Jul 4, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation Jul 4, 2020
Copy link
Member

@kvark kvark left a comment

General implementation is all good. There is one spot that needs to be a bit reworked.

components/script/dom/gpuqueue.rs Show resolved Hide resolved
components/script/dom/gpuqueue.rs Outdated Show resolved Hide resolved
components/script/dom/gpuqueue.rs Show resolved Hide resolved
components/script/dom/gpuqueue.rs Show resolved Hide resolved
kvark
kvark approved these changes Jul 4, 2020
Copy link
Member

@kvark kvark left a comment

Looks like everything is resolved

@kvark
Copy link
Member

kvark commented Jul 4, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2020

📌 Commit fae6608 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2020

Testing commit fae6608 with merge 2ad2ed1...

bors-servo added a commit that referenced this issue Jul 4, 2020
Implement GPUQueue write methods and update wgpu-core

<!-- Please describe your changes on the following line: -->
Implements `GPUQueue.writeBuffer` and `GPUQueue.writeTexture`.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2020

💔 Test failed - status-taskcluster

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

Testing commit fae6608 with merge c739429...

bors-servo added a commit that referenced this issue Jul 5, 2020
Implement GPUQueue write methods and update wgpu-core

<!-- Please describe your changes on the following line: -->
Implements `GPUQueue.writeBuffer` and `GPUQueue.writeTexture`.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

💔 Test failed - status-taskcluster

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

Testing commit fae6608 with merge f2e6f34...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing f2e6f34 to master...

@bors-servo bors-servo merged commit f2e6f34 into servo:master Jul 5, 2020
2 checks passed
WebGPU MVP automation moved this from In progress to Done Jul 5, 2020
@kunalmohan kunalmohan deleted the gpu-queue-write branch Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
WebGPU MVP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants