Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fire `invalid` event on form elements #27174

Merged
merged 1 commit into from Jul 5, 2020
Merged

Do not fire `invalid` event on form elements #27174

merged 1 commit into from Jul 5, 2020

Conversation

@muodov
Copy link
Contributor

muodov commented Jul 4, 2020 •
edited

This is a follow-up to my previous PR suggested by @gterzian.

invalid event on the <form> element has been recently removed from the spec.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27133
@muodov
Remove `invalid` event on a form element
Loading status checks…
7fd903c
@highfive
Copy link

highfive commented Jul 4, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.
@highfive
Copy link

highfive commented Jul 4, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlformelement.rs
  • @KiChjang: components/script/dom/htmlformelement.rs
@muodov muodov changed the title Remove `invalid` event on a form element Do not fire `invalid` event on form elements Jul 4, 2020
@gterzian
Copy link
Member

gterzian commented Jul 5, 2020 •
edited

Thanks! Re closing the issue, we might want to keep it open regarding checkValidity and others, depending on the outcome of the discussion.

This is a follow-up to my previous PR suggested by @gterzian.

It's better not to @ mention people in the opening statement of the PR, because if you do that, that person gets a lot of notifications as part of the bors merge process...

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

📌 Commit 7fd903c has been approved by gterzian
@highfive highfive assigned gterzian and unassigned asajeffrey Jul 5, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

⌛ Testing commit 7fd903c with merge 154c68a...
bors-servo added a commit that referenced this pull request Jul 5, 2020
@bors-servo
Auto merge of #27174 - muodov:form-invalid-event-removal, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
154c68a 
Do not fire `invalid` event on form elements

This is a follow-up to my [previous PR](#27100) suggested by @gterzian.

`invalid` event on the `<form>` element has been [recently removed](whatwg/html#4626) from the spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27133

<!-- Either: -->
- [x] [WPT test](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/historical.window.js) marked as passing
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

📌 Commit 7fd903c has been approved by gterzian
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

⌛ Testing commit 7fd903c with merge d93e67a...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2020

☀️ Test successful - status-taskcluster
Approved by: gterzian
Pushing d93e67a to master...
@bors-servo bors-servo merged commit d93e67a into servo:master Jul 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@muodov muodov deleted the muodov:form-invalid-event-removal branch Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gterzian gterzian

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Improve spec compliance of validity check
5 participants
@muodov @highfive @gterzian @bors-servo @asajeffrey
You can’t perform that action at this time.