New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fire invalid
event on form elements
#27174
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
Heads up! This PR modifies the following files:
|
invalid
event on a form elementinvalid
event on form elements
Thanks! Re closing the issue, we might want to keep it open regarding
It's better not to @ mention people in the opening statement of the PR, because if you do that, that person gets a lot of notifications as part of the bors merge process... @bors-servo r+ |
|
Do not fire `invalid` event on form elements This is a follow-up to my [previous PR](#27100) suggested by @gterzian. `invalid` event on the `<form>` element has been [recently removed](whatwg/html#4626) from the spec. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27133 <!-- Either: --> - [x] [WPT test](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/historical.window.js) marked as passing
|
|
|
This is a follow-up to my previous PR suggested by @gterzian.
invalid
event on the<form>
element has been recently removed from the spec../mach build -d
does not report any errors./mach test-tidy
does not report any errors