Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail out from font loading if no default font can be loaded. #27184

Merged
merged 1 commit into from Jul 7, 2020

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 6, 2020

The font loading setup in font-kit doesn't quite work in UWP yet. This change avoids panics in web content that calls fillText while that is the case.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27166
  • These changes do not require tests because they only occur on platforms that we can't test.

@jdm
Copy link
Member Author

jdm commented Jul 6, 2020

r? @asajeffrey

@highfive highfive assigned asajeffrey and unassigned SimonSapin Jul 6, 2020
@asajeffrey
Copy link
Member

asajeffrey commented Jul 7, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

📌 Commit 8e33806 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

Testing commit 8e33806 with merge 4a0cd44...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 4a0cd44 to master...

@bors-servo bors-servo merged commit 4a0cd44 into servo:master Jul 7, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants