Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net: in the absense of a request body, assume streaming it cannot fail #27192

Merged
merged 1 commit into from Jul 7, 2020
Merged

Net: in the absense of a request body, assume streaming it cannot fail #27192

merged 1 commit into from Jul 7, 2020
+11 −1

Conversation

@gterzian
Copy link
Member

gterzian commented Jul 7, 2020

FIX #27185

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Jul 7, 2020

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Jul 7, 2020

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@gterzian
Copy link
Member Author

gterzian commented Jul 7, 2020

@jdm r?
@gterzian gterzian force-pushed the gterzian:no_body_no_channel branch from f921bb8 to 1df71b2 Jul 7, 2020
@gterzian
net: in the absense of a request body, assume streaming it cannot fail
Loading status checks…
7d4b256
@gterzian gterzian force-pushed the gterzian:no_body_no_channel branch from 1df71b2 to 7d4b256 Jul 7, 2020
@jdm
Copy link
Member

jdm commented Jul 7, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

📌 Commit 7d4b256 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jul 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

⌛ Testing commit 7d4b256 with merge 1b38197...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 1b38197 to master...
@bors-servo bors-servo merged commit 1b38197 into servo:master Jul 7, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:no_body_no_channel branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Many warnings about request stream confirmations when loading pages
5 participants
@gterzian @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.