Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reliability of hang monitor tests #27193

Merged
merged 1 commit into from Jul 7, 2020

Conversation

@gterzian
Copy link
Member

gterzian commented Jul 7, 2020

FIX #27191


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@gterzian
Copy link
Member Author

gterzian commented Jul 7, 2020

@jdm r?

@jdm
Copy link
Member

jdm commented Jul 7, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

📌 Commit 256167e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

Testing commit 256167e with merge 840167e...

bors-servo added a commit that referenced this pull request Jul 7, 2020
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 7, 2020

bors-servo added a commit that referenced this pull request Jul 7, 2020
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

Testing commit 256167e with merge 2a95233...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 7, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

Testing commit 256167e with merge e616284...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e616284 to master...

@bors-servo bors-servo merged commit e616284 into servo:master Jul 7, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:fix_monitor_test_timeout branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.