Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webxr cubemap and spherical 360 rendering #27224

Merged
merged 1 commit into from Jul 9, 2020

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 9, 2020

Part of rendering webxr content as 360 video


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's back-end rendering

@highfive
Copy link

highfive commented Jul 9, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/xrviewerpose.rs

@highfive
Copy link

highfive commented Jul 9, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 9, 2020

The matching webxr PR is servo/webxr#181

@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 9, 2020

r? @Manishearth

@highfive highfive assigned Manishearth and unassigned SimonSapin Jul 9, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 9, 2020

Screenshot from 2020-07-09 11-44-07

@asajeffrey asajeffrey force-pushed the webxr-glwindow-spherical branch from 8451eec to 29f051b Compare Jul 9, 2020
@asajeffrey asajeffrey force-pushed the webxr-glwindow-spherical branch from 29f051b to a2142d7 Compare Jul 9, 2020
@asajeffrey asajeffrey marked this pull request as ready for review Jul 9, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 9, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 9, 2020

📌 Commit a2142d7 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 9, 2020

Testing commit a2142d7 with merge 7521dfb...

bors-servo added a commit that referenced this issue Jul 9, 2020
…arth

Add support for webxr cubemap and spherical 360 rendering

<!-- Please describe your changes on the following line: -->

Part of rendering webxr content as 360 video

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it's back-end rendering

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 9, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 9, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jul 9, 2020

Testing commit a2142d7 with merge 714acb9...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 9, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 714acb9 to master...

@bors-servo bors-servo merged commit 714acb9 into servo:master Jul 9, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-xr-zomg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants