Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XRSession.inputSources iterable #27227

Merged
merged 2 commits into from Jul 10, 2020
Merged

Make XRSession.inputSources iterable #27227

merged 2 commits into from Jul 10, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jul 10, 2020

Fixes #27130.
@highfive
Copy link

highfive commented Jul 10, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/webidls/TextMetrics.webidl, components/script/dom/webidls/CustomElementRegistry.webidl, components/script/dom/webidls/CompositionEvent.webidl, components/script/dom/webidls/CanvasRenderingContext2D.webidl and 1 more
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/webidls/TextMetrics.webidl, components/script/dom/webidls/CustomElementRegistry.webidl, components/script/dom/webidls/CompositionEvent.webidl, components/script/dom/webidls/CanvasRenderingContext2D.webidl and 1 more
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Jul 10, 2020
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Trying commit d89a382 with merge 3014c2e...
bors-servo added a commit that referenced this pull request Jul 10, 2020
@bors-servo
Auto merge of #27227 - jdm:iterable, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3014c2e 
Make XRSession.inputSources iterable

Fixes #27130.
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jul 10, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jul 10, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24548.
@Manishearth
Manishearth approved these changes Jul 10, 2020
View changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:iterable branch from d89a382 to a1c7a9a Jul 10, 2020
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

📌 Commit a1c7a9a has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Jul 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit a1c7a9a with merge 1f87ed3...
bors-servo added a commit that referenced this pull request Jul 10, 2020
@bors-servo
Auto merge of #27227 - jdm:iterable, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f87ed3 
Make XRSession.inputSources iterable

Fixes #27130.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jul 10, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24548.
@jdm jdm force-pushed the jdm:iterable branch from a1c7a9a to 84be9b7 Jul 10, 2020
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

📌 Commit 84be9b7 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Jul 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit 84be9b7 with merge efeb9df...
bors-servo added a commit that referenced this pull request Jul 10, 2020
@bors-servo
Auto merge of #27227 - jdm:iterable, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efeb9df 
Make XRSession.inputSources iterable

Fixes #27130.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jul 10, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24548.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

💔 Test failed - status-taskcluster
jdm added 2 commits Jul 10, 2020
@jdm
dom: Use pref macro for IDL conditional guards.
aa80f91
@jdm
dom: Generate iterator symbol for interfaces with indexed getters.
Loading status checks…
63528f6
@jdm jdm force-pushed the jdm:iterable branch from 84be9b7 to 63528f6 Jul 10, 2020
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Trying commit 63528f6 with merge 699408a...
bors-servo added a commit that referenced this pull request Jul 10, 2020
@bors-servo
Auto merge of #27227 - jdm:iterable, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
699408a 
Make XRSession.inputSources iterable

Fixes #27130.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jul 10, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24548.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Jul 10, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

📌 Commit 63528f6 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit 63528f6 with merge 9094e1d...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 9094e1d to master...
@bors-servo bors-servo merged commit 9094e1d into servo:master Jul 10, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Unity export doesn't load
6 participants
@jdm @highfive @bors-servo @servo-wpt-sync @Manishearth @nox
You can’t perform that action at this time.