Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updevtools: TabDescription actor #27229
Merged
+148
−28
Conversation
|
Thanks for investigating this! |
components/devtools/actors/tab.rs
Outdated
| pub title: RefCell<String>, | ||
| pub url: RefCell<String>, |
Comment on lines
39
to
40
This comment has been minimized.
This comment has been minimized.
jdm
Jul 10, 2020
Member
Rather than duplicating this data in TabDescriptorActor and BrowsingContextActor, could we choose one of them?
paulrouget
force-pushed the
paulrouget:devtools_protocol_update
branch
from
fabc6dc
to
da80d4f
|
@jdm that's probably a better approach. |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 10, 2020
We could do better by creating the browsing context actor lazily, but that's good enough to re-enable devtools with a recent version of Firefox. fix #27113.