Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test path for manifest during WPT syncing. #27230

Merged
merged 2 commits into from Jul 10, 2020
+7 −14
Merged

Add missing test path for manifest during WPT syncing. #27230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aec3ce8
Add missing test path for manifest during WPT syncing.
jdm Jul 10, 2020
f84d03b
Merge loading and updating manifest states when syncing.
jdm Jul 10, 2020
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…

Add missing test path for manifest during WPT syncing.

  • Loading branch information
@jdm
jdm committed Jul 10, 2020
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
commit aec3ce801b70c6da6f38aaf2d25375a1fc4907b6
2 tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/update/sync.py
View file
Open in desktop
@@ -100,7 +100,7 @@ class LoadManifest(Step):
def create(self, state):
from manifest import manifest
state.manifest_path = os.path.join(state.metadata_path, "MANIFEST.json")
state.test_manifest = manifest.Manifest("/")
state.test_manifest = manifest.Manifest(state.sync["path"], "/")

This comment has been minimized.

Sign in to view
Copy link
@jgraham

jgraham Jul 10, 2020

Contributor

Is this different to state.tests_path?

This comment has been minimized.

Sign in to view
Copy link
@jgraham

jgraham Jul 10, 2020

Contributor

I guess we use it with manifest.update so it seem fine.

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Jul 10, 2020

Author Member

When I used state.tests_path, I got exceptions for files that existed in the sync tree and not in the pre-sync tree.


class UpdateManifest(Step):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.