Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support depth and stencil in webxr #27232

Merged
merged 1 commit into from Jul 11, 2020
Merged

Support depth and stencil in webxr #27232

merged 1 commit into from Jul 11, 2020
+42 −19

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 10, 2020 •
edited

Creates a DEPTH_STENCIL attachment if one is provided by the webxr device.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't reftest webxr
@highfive
Copy link

highfive commented Jul 10, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/xrwebgllayer.rs
@highfive
Copy link

highfive commented Jul 10, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 10, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Jul 10, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 10, 2020

The webxr PR is servo/webxr#182
@Manishearth
Manishearth approved these changes Jul 10, 2020
View changes
@asajeffrey
Support depth and stencil in webxr
Loading status checks…
a9bb3f7
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-depth-stencil branch from 4d84fa7 to a9bb3f7 Jul 10, 2020
@asajeffrey asajeffrey marked this pull request as ready for review Jul 10, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 10, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

📌 Commit a9bb3f7 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2020

⌛ Testing commit a9bb3f7 with merge 242e7e2...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 242e7e2 to master...
@bors-servo bors-servo merged commit 242e7e2 into servo:master Jul 11, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@asajeffrey asajeffrey mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@asajeffrey @highfive @bors-servo @Manishearth @nox
You can’t perform that action at this time.