Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a sessionavailable event that allows content to enter an XR session without a user gesture #27235
+68
−1
Conversation
…on without a user gesture
highfive
commented
Jul 10, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 10, 2020
|
|
|
Should I add a test in the |
|
That sounds reasonable. |
|
An automated test would be nice. |
|
Added a test. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 10, 2020
Add a sessionavailable event that allows content to enter an XR session without a user gesture <!-- Please describe your changes on the following line: --> This allows servo to implement immersive web apps. https://immersive-web.github.io/webxr/#application-launch --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because I'm not sure we should have a WPT for something this non-standard. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
asajeffrey
force-pushed the
asajeffrey:webxr-sessionavailable
branch
from
1af1dc0
to
a6da5dc
|
Grr, thank you emacs. @bors-servo r=jdm |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 10, 2020
This allows servo to implement immersive web apps. https://immersive-web.github.io/webxr/#application-launch
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors